Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node.js from v14.21.3 to v18.15.0 #3608

Closed
wants to merge 1 commit into from
Closed

Bump node.js from v14.21.3 to v18.15.0 #3608

wants to merge 1 commit into from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Mar 14, 2023

Description

Revert "add node fiber to improve performance (#2319)"
Revert "[CVE-2022-25758] Use dart-sass instead of node-sass (#2054)"
Revert back to use node-sass and bump to 8.0.0
Change lmdb-store to lmdb
Bump node.js to 18 and fix errors

Issues Resolved

#3601

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh self-assigned this Mar 14, 2023
@ananzh ananzh requested a review from a team as a code owner March 14, 2023 16:11
@ananzh ananzh changed the title Bump node.js from v14.20.1 to v18.12.0 Bump node.js from v14.20.1 to v18.15.0 Mar 14, 2023
@ananzh ananzh changed the title Bump node.js from v14.20.1 to v18.15.0 Bump node.js from v14.21.3 to v18.15.0 Mar 14, 2023
@ananzh ananzh force-pushed the bump-nodejs-18-node-sass branch 6 times, most recently from 8e16947 to d0f49c6 Compare March 15, 2023 20:31
@ananzh ananzh added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Mar 15, 2023
@ananzh ananzh force-pushed the bump-nodejs-18-node-sass branch 2 times, most recently from e79062d to daedc87 Compare March 16, 2023 18:29
@ananzh ananzh marked this pull request as draft April 11, 2023 17:35
@ananzh
Bump node.js from v14.21.3 to v18.15.0
ca60f16 
Revert "add node fiber to improve performance (opensearch-project#2319)"
Revert "[CVE-2022-25758] Use dart-sass instead of node-sass (opensearch-project#2054)"
Revert back to use node-sass and bump to 8.0.0
Change lmdb-store to lmdb
Bump node.js to 18 and fix errors

Issue Resolved:
opensearch-project#3601

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh force-pushed the bump-nodejs-18-node-sass branch from daedc87 to ca60f16 Compare April 18, 2023 17:13
@codecov-commenter
Copy link

Codecov Report

Merging #3608 (ca60f16) into main (9d27023) will decrease coverage by 0.15%.
The diff coverage is 71.42%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3608      +/-   ##
==========================================
- Coverage   66.44%   66.29%   -0.15%     
==========================================
  Files        3227     3227              
  Lines       62051    62064      +13     
  Branches     9593     9599       +6     
==========================================
- Hits        41227    41143      -84     
- Misses      18523    18602      +79     
- Partials     2301     2319      +18
Flag Coverage Δ
Linux 66.29% <71.42%> (-0.10%) ⬇️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/osd-dev-utils/src/proc_runner/proc.ts 6.52% <0.00%> (ø)
...ages/osd-optimizer/src/optimizer/observe_worker.ts 16.36% <ø> (ø)
src/core/server/status/status_service.ts 78.94% <ø> (ø)
...core/server/plugins/discovery/plugins_discovery.ts 80.95% <33.33%> (-4.05%) ⬇️
src/core/server/bootstrap.ts 2.85% <50.00%> (+2.85%) ⬆️
...ection/public/components/opt_in_example_flyout.tsx 65.00% <62.50%> (-1.67%) ⬇️
...es/osd-optimizer/src/optimizer/optimizer_config.ts 74.57% <83.33%> (-20.07%) ⬇️
packages/osd-optimizer/src/node/cache.ts 55.00% <88.88%> (+1.05%) ⬆️
src/core/server/http/router/request.ts 98.07% <100.00%> (ø)
...server/plugins/discovery/plugin_manifest_parser.ts 83.05% <100.00%> (+0.29%) ⬆️
... and 1 more

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashwin-pc ashwin-pc mentioned this pull request May 4, 2023
Closed
9 tasks
@joshuarrrr
Copy link
Member

@ananzh Should this PR be closed in favor of #4071? In any case, I'll remove the 2.8.0 label for now.

@joshuarrrr joshuarrrr removed the v2.8.0 label May 25, 2023
@ananzh
Copy link
Member Author

ananzh commented May 26, 2023

@joshuarrrr thanks. since we decides to use patched webpack in #4071, close this PR.

@ananzh ananzh closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla Awaiting requested review from kavilla kavilla will be requested when the pull request is marked ready for review kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki will be requested when the pull request is marked ready for review AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 will be requested when the pull request is marked ready for review abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon will be requested when the pull request is marked ready for review zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs will be requested when the pull request is marked ready for review manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq will be requested when the pull request is marked ready for review curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT will be requested when the pull request is marked ready for review BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba will be requested when the pull request is marked ready for review xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi will be requested when the pull request is marked ready for review zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 will be requested when the pull request is marked ready for review LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi will be requested when the pull request is marked ready for review virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli will be requested when the pull request is marked ready for review sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 will be requested when the pull request is marked ready for review joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo will be requested when the pull request is marked ready for review huyaboo is a code owner

Assignees

@ananzh ananzh

Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananzh @codecov-commenter @joshuarrrr @abbyhu2000